Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed WIN64 to WIN_64 #2774

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Renamed WIN64 to WIN_64 #2774

merged 1 commit into from
Dec 11, 2023

Conversation

braw-lee
Copy link
Contributor

@braw-lee braw-lee commented Dec 9, 2023

Fixes issue #2768

gcc/rust/ChangeLog:

* backend/rust-compile-base.cc (HIRCompileBase::setup_abi_options): Renamed `WIN64` to `WIN_64`
* util/rust-abi.cc (get_abi_from_string): Likewise
(get_string_from_abi): Likewise
* util/rust-abi.h (enum ABI): Likewise

Thank you for making Rust GCC better!

If your PR fixes an issue, you can add "Fixes #issue_number" into this
PR description and the git commit message. This way the issue will be
automatically closed when your PR is merged. If your change addresses
an issue but does not fully fix it please mark it as "Addresses #issue_number"
in the git commit message.

Here is a checklist to help you with your PR.

Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.

*Please write a comment explaining your change. This is the message
that will be part of the merge commit.

@braw-lee braw-lee force-pushed the firstFix branch 2 times, most recently from 83b4990 to 3bc7aff Compare December 9, 2023 08:21
Fixes issue Rust-GCC#2768

gcc/rust/ChangeLog:

	* backend/rust-compile-base.cc (HIRCompileBase::setup_abi_options):
	Renamed `WIN64` to `WIN_64`
	* util/rust-abi.cc (get_abi_from_string): Likewise
	(get_string_from_abi): Likewise
	* util/rust-abi.h (enum ABI): Likewise

Signed-off-by: Kushal Pal <[email protected]>
@braw-lee
Copy link
Contributor Author

braw-lee commented Dec 9, 2023

resolves #2768
Sorry for the force-commits, they are nothing but me trying to satisfy the GNU commit format checker.
Let me know if the PR is acceptable or not (this is my first PR to Rust-GCC)
@CohenArthur

@dkm
Copy link
Member

dkm commented Dec 10, 2023

Hello @braw-lee !
Thanks for your contribution! Have you read https://gcc.gnu.org/dco.html? We would need a simple message that clearly states you've read and acknowledge it.

@P-E-P
Copy link
Member

P-E-P commented Dec 10, 2023

resolves #2768 Sorry for the force-commits, they are nothing but me trying to satisfy the GNU commit format checker. Let me know if the PR is acceptable or not (this is my first PR to Rust-GCC)

Don't worry about force pushes on your own branches, most people force push and rewrite their history a lot

@P-E-P P-E-P requested a review from CohenArthur December 10, 2023 20:19
@P-E-P P-E-P added this to the GCC 14.1 release milestone Dec 10, 2023
@P-E-P P-E-P linked an issue Dec 10, 2023 that may be closed by this pull request
@braw-lee
Copy link
Contributor Author

Hello @braw-lee ! Thanks for your contribution! Have you read https://gcc.gnu.org/dco.html? We would need a simple message that clearly states you've read and acknowledge it.

Yes, I have read and acknowledged https://gcc.gnu.org/dco.html

Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philberty philberty added this pull request to the merge queue Dec 11, 2023
Merged via the queue into Rust-GCC:master with commit 3589329 Dec 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WIN64 is a predefined constant by GCC on MinGW-w64
4 participants