Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIN64 is a predefined constant by GCC on MinGW-w64 #2768

Closed
MehdiChinoune opened this issue Dec 1, 2023 · 5 comments · Fixed by #2774
Closed

WIN64 is a predefined constant by GCC on MinGW-w64 #2768

MehdiChinoune opened this issue Dec 1, 2023 · 5 comments · Fixed by #2774
Labels
bug good-first-pr

Comments

@MehdiChinoune
Copy link

Original bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109853
@CohenArthur
Copy link
Member

thanks! I'll mark this as a good first issue since it's quite easy to fix and it's been there forever haha

@braw-lee
Copy link
Contributor

braw-lee commented Dec 9, 2023

Hi, I would like to work on this.
From what I understand I should replace all occurrences of WIN64 enum to something else , lets say WIN_64
Let me know if there's more to it @CohenArthur

@MehdiChinoune
Copy link
Author

MehdiChinoune commented Dec 9, 2023 •
edited
Loading

I have already created a patch https://github.com/msys2/MINGW-packages/blob/8341179b/mingw-w64-gcc/2001-fix-building-rust-on-mingw-w64.patch
but It applies to gcc-13

@braw-lee
Copy link
Contributor

braw-lee commented Dec 9, 2023

Does that mean we don't need to fix it here? @MehdiChinoune

@MehdiChinoune
Copy link
Author

Does that mean we don't need to fix it here? @MehdiChinoune

No, I haven't said that, I just say that you could use my patch.

braw-lee added a commit to braw-lee/gccrs that referenced this issue Dec 9, 2023
@braw-lee
Renamed WIN64 to WIN_64
cbd5f85 
Fixes issue Rust-GCC#2768

gcc/rust/ChangeLog:

	* backend/rust-compile-base.cc (HIRCompileBase::setup_abi_options): Renamed `WIN64` to `WIN_64`
	* util/rust-abi.cc (get_abi_from_string): Likewise
	(get_string_from_abi): Likewise
	* util/rust-abi.h (enum ABI): Likewise

Signed-off-by: Kushal Pal <[email protected]>
@braw-lee braw-lee mentioned this issue Dec 9, 2023
Merged
braw-lee added a commit to braw-lee/gccrs that referenced this issue Dec 9, 2023
@braw-lee
Renamed WIN64 to WIN_64
83b4990 
Fixes issue Rust-GCC#2768

gcc/rust/ChangeLog:

	* backend/rust-compile-base.cc (HIRCompileBase::setup_abi_options):
            Renamed `WIN64` to `WIN_64`
	* util/rust-abi.cc (get_abi_from_string): Likewise
	(get_string_from_abi): Likewise
	* util/rust-abi.h (enum ABI): Likewise

Signed-off-by: Kushal Pal <[email protected]>
braw-lee added a commit to braw-lee/gccrs that referenced this issue Dec 9, 2023
@braw-lee
Renamed WIN64 to WIN_64
3bc7aff 
Fixes issue Rust-GCC#2768

gcc/rust/ChangeLog:

	* backend/rust-compile-base.cc (HIRCompileBase::setup_abi_options):
        Renamed `WIN64` to `WIN_64`
	* util/rust-abi.cc (get_abi_from_string): Likewise
	(get_string_from_abi): Likewise
	* util/rust-abi.h (enum ABI): Likewise

Signed-off-by: Kushal Pal <[email protected]>
braw-lee added a commit to braw-lee/gccrs that referenced this issue Dec 9, 2023
@braw-lee
Renamed WIN64 to WIN_64
95526c5 
Fixes issue Rust-GCC#2768

gcc/rust/ChangeLog:

	* backend/rust-compile-base.cc (HIRCompileBase::setup_abi_options):
	Renamed `WIN64` to `WIN_64`
	* util/rust-abi.cc (get_abi_from_string): Likewise
	(get_string_from_abi): Likewise
	* util/rust-abi.h (enum ABI): Likewise

Signed-off-by: Kushal Pal <[email protected]>
@P-E-P P-E-P linked a pull request Dec 10, 2023 that will close this issue
Renamed WIN64 to WIN_64 #2774
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 11, 2023
@braw-lee @philberty
Renamed WIN64 to WIN_64
3589329 
Fixes issue #2768

gcc/rust/ChangeLog:

	* backend/rust-compile-base.cc (HIRCompileBase::setup_abi_options):
	Renamed `WIN64` to `WIN_64`
	* util/rust-abi.cc (get_abi_from_string): Likewise
	(get_string_from_abi): Likewise
	* util/rust-abi.h (enum ABI): Likewise

Signed-off-by: Kushal Pal <[email protected]>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 17, 2024
@braw-lee @CohenArthur
Renamed WIN64 to WIN_64
56d6cc2 
Fixes issue Rust-GCC#2768

gcc/rust/ChangeLog:

	* backend/rust-compile-base.cc (HIRCompileBase::setup_abi_options):
	Renamed `WIN64` to `WIN_64`
	* util/rust-abi.cc (get_abi_from_string): Likewise
	(get_string_from_abi): Likewise
	* util/rust-abi.h (enum ABI): Likewise

Signed-off-by: Kushal Pal <[email protected]>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 26, 2024
@braw-lee @CohenArthur
Renamed WIN64 to WIN_64
48dd00b 
Fixes issue Rust-GCC#2768

gcc/rust/ChangeLog:

	* backend/rust-compile-base.cc (HIRCompileBase::setup_abi_options):
	Renamed `WIN64` to `WIN_64`
	* util/rust-abi.cc (get_abi_from_string): Likewise
	(get_string_from_abi): Likewise
	* util/rust-abi.h (enum ABI): Likewise

Signed-off-by: Kushal Pal <[email protected]>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 26, 2024
@braw-lee @CohenArthur
gccrs: Renamed WIN64 to WIN_64
48d1fb8 
Fixes issue Rust-GCC#2768

gcc/rust/ChangeLog:

	* backend/rust-compile-base.cc (HIRCompileBase::setup_abi_options):
	Renamed `WIN64` to `WIN_64`
	* util/rust-abi.cc (get_abi_from_string): Likewise
	(get_string_from_abi): Likewise
	* util/rust-abi.h (enum ABI): Likewise

Signed-off-by: Kushal Pal <[email protected]>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Feb 5, 2024
@braw-lee @CohenArthur
gccrs: Renamed WIN64 to WIN_64
d7b2d67 
Fixes issue Rust-GCC#2768

gcc/rust/ChangeLog:

	* backend/rust-compile-base.cc (HIRCompileBase::setup_abi_options):
	Renamed `WIN64` to `WIN_64`
	* util/rust-abi.cc (get_abi_from_string): Likewise
	(get_string_from_abi): Likewise
	* util/rust-abi.h (enum ABI): Likewise

Signed-off-by: Kushal Pal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good-first-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renamed WIN64 to WIN_64 braw-lee/gccrs
3 participants
@CohenArthur @MehdiChinoune @braw-lee