Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RK-19823 - add new DOP params #85

Closed
wants to merge 4 commits into from
Closed

RK-19823 - add new DOP params #85

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b03ad0
add new DOP params
DavidRBiderman Sep 14, 2023
edc4d97
update datastore version
DavidRBiderman Sep 14, 2023
c591ba0
update README
DavidRBiderman Sep 18, 2023
27e3fcd
generate new helm-chart
DavidRBiderman Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/datastore/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: "1.0.11"
description: A Helm chart for Rookout Data-On-Prem component on Kubernetes
icon: https://raw.githubusercontent.com/Rookout/helm-charts/master/Rookout-logo.png
name: datastore
version: 0.1.48
version: 0.1.49
home: "http://rookout.com/"
maintainers:
- name: Rookout
Expand Down
2 changes: 2 additions & 0 deletions charts/datastore/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ spec:
value: {{ default 8080 .Values.datastore.dopContainerPort | quote }}
- name: ROOKOUT_DOP_AUTO_TLS_DOMAIN
value: {{ .Values.datastore.autoTlsDomain | quote }}
- name: ROOKOUT_DOP_DAO_ACTIVE
value: {{ .Values.datastore.enableNewDao }}
{{ if (eq (required "datastore.serverMode is required" .Values.datastore.serverMode) "AUTOTLS") }}
- name: ROOKOUT_DOP_ENABLE_FILE_LOGGER
value: "False"
Expand Down
1 change: 1 addition & 0 deletions charts/datastore/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ datastore:
servicePortTLS: ''
logging:
enabled: false
enableNewDao: false

service:
type: LoadBalancer
Expand Down
1 change: 1 addition & 0 deletions charts/rookout-hybrid/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ helm upgrade --install rookout rookout/rookout-hybrid \
| datastore.serviceAccount.create | bool | `true` | Specifies whether a service account should be created |
| datastore.serviceAccount.name | string | `""` | The name of the service account to use. If not set and create is true, a name is generated using the fullname template |
| datastore.tolerations | list | `[]` | [Tolerations] for use with node taints |
| datastore.enableNewDao | bool | `false` | Enable new SQL connector and new DAO schema
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not also recommend increasing the cpu in that case?

Copy link
Author

@DavidRBiderman DavidRBiderman Sep 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ElDuderinos received all the disclaimers. It does not require nothing but it is recommended that the client increase resources generally speaking. This is not a mandatory step

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gosharo Should we bump to 0.3.2 (at the top)?

| imagePullSecrets | list | `[]` | Secrets with credentials to pull images from a private registry. Registry secret names as an array. |
| rookout.controllerTLSSecretName | string | `""` | Rookout's controller TLS secert used when rookout.serverMode: "TLS" The components expect to find "tls.key" and "tls.crt" keys in the secert |
| rookout.datastoreTLSSecretName | string | `""` | Rookout's datastore TLS secert used when rookout.serverMode: "TLS" The components expect to find "tls.key" and "tls.crt" keys in the secert |
Expand Down
2 changes: 2 additions & 0 deletions charts/rookout-hybrid/templates/datastore-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ spec:
value: {{ required "rookout.serverMode is required" .Values.rookout.serverMode | quote }}
- name: ROOKOUT_DOP_PORT
value: "8080"
- name: ROOKOUT_DOP_DAO_ACTIVE
value: {{ .Values.datastore.enableNewDao }}
{{- with .Values.datastore.extraEnv }}
{{- toYaml . | nindent 12 }}
{{- end }}
Expand Down
3 changes: 3 additions & 0 deletions charts/rookout-hybrid/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,9 @@ datastore:
# -- whether to deploy a Datastore
enabled: true

# -- whether to enable the new DAO wrappers for the datastore
enableNewDao: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add it to the readme


image:
# -- Rookout's Datastore image name
name: data-on-prem
Expand Down
Loading