RK-19823 - add new DOP params #85
Conversation
|
Github Enforcer opened Task: RK-19823 |
| @@ -163,6 +163,9 @@ datastore: | |||
| # -- whether to deploy a Datastore | |||
| enabled: true | |||
|
|
|||
| # -- whether to enable the new DAO wrappers for the datastore | |||
| enableNewDao: false | |||
There was a problem hiding this comment.
You need to add it to the readme
There was a problem hiding this comment.
@DavidRBiderman why do you change these chart? It is customer-facing and deprecated
https://github.com/Rookout/helm-charts#available-charts
|
charts/rookout-hybrid/README.md
Outdated
| @@ -125,6 +125,7 @@ helm upgrade --install rookout rookout/rookout-hybrid \ | |||
| | datastore.serviceAccount.create | bool | `true` | Specifies whether a service account should be created | | |||
| | datastore.serviceAccount.name | string | `""` | The name of the service account to use. If not set and create is true, a name is generated using the fullname template | | |||
| | datastore.tolerations | list | `[]` | [Tolerations] for use with node taints | | |||
| | datastore.enableNewDao | bool | `false` | Enable new SQL connector and new DAO schema | |||
There was a problem hiding this comment.
Should we not also recommend increasing the cpu in that case?
There was a problem hiding this comment.
@ElDuderinos received all the disclaimers. It does not require nothing but it is recommended that the client increase resources generally speaking. This is not a mandatory step
charts/rookout-hybrid/README.md
Outdated
| @@ -125,6 +125,7 @@ helm upgrade --install rookout rookout/rookout-hybrid \ | |||
| | datastore.serviceAccount.create | bool | `true` | Specifies whether a service account should be created | | |||
| | datastore.serviceAccount.name | string | `""` | The name of the service account to use. If not set and create is true, a name is generated using the fullname template | | |||
| | datastore.tolerations | list | `[]` | [Tolerations] for use with node taints | | |||
| | datastore.enableNewDao | bool | `false` | Enable new SQL connector and new DAO schema | |||
There was a problem hiding this comment.
@gosharo Should we bump to 0.3.2 (at the top)?
|
as @DavidRBiderman asked me to tag, |
No description provided.