Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/GH-70 upcoming events page issue #71

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,15 @@ jobs:
runs-on: ubuntu-22.04
env:
HUSKY: '0'
TZ: 'Europe/Rome'
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: pnpm/action-setup@v2
- uses: actions/setup-node@v3
with:
node-version: 'v18.17.0'
node-version-file: '.nvmrc'
FaberVitale marked this conversation as resolved.
Show resolved Hide resolved
cache: 'pnpm'
- name: log info
run: >
Expand All @@ -29,5 +30,7 @@ jobs:
run: pnpm run lint:ts
- name: lint - astro
run: pnpm run lint:astro
- name: tests
run: pnpm run test
- name: Build
run: pnpm run build
3 changes: 2 additions & 1 deletion .github/workflows/deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
runs-on: ubuntu-22.04
env:
HUSKY: '0'
TZ: 'Europe/Rome'
PUBLIC_SITE_URL: "https://romajs.org"
steps:
- name: Checkout 🛎️
Expand All @@ -22,7 +23,7 @@ jobs:
- uses: pnpm/action-setup@v2
- uses: actions/setup-node@v3
with:
node-version: 'v18.17.0'
node-version-file: '.nvmrc'
cache: 'pnpm'
- name: Install dependencies
run: pnpm install --frozen-lockfile
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.17.0
v20.11.1
2 changes: 1 addition & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"editor.insertSpaces": true,
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true
"source.fixAll.eslint": "explicit"
},
"[javascript]": {
"editor.formatOnSave": false
Expand Down
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ The new RomaJS website built with [astro](https://astro.build/) and [SolidJS](ht
- Blog section.
- Blog category pages.
- Upcoming events page.
- Previous events page.
- [feed rss](https://rss.com/blog/how-do-rss-feeds-work/) available at `<SITE>/blog/rss.xml`.
- opengraph and twitter social cards.
- headless blog posts available at `/api/blog/post.json`.
Expand All @@ -26,7 +27,6 @@ The new RomaJS website built with [astro](https://astro.build/) and [SolidJS](ht
- [x] github action pipeline that deploys to github pages
- [x] blog post categories pages
- [x] categories index page
- [ ] blog post authors pages
FaberVitale marked this conversation as resolved.
Show resolved Hide resolved
- [x] blog post comments powered by [giscus](https://giscus.app/)
- [x] copy facebook posts 2022, 2020, 2019
- [x] generate blog homepage
Expand All @@ -51,7 +51,7 @@ nvm use

#### pnpm & corepack

You do not need to install [`pnpm`](https://pnpm.io), you just need have [`node 18`](https://nodejs.org/en/) installed and then enable [`corepack`](https://nodejs.org/api/corepack.html):
You do not need to install [`pnpm`](https://pnpm.io), you just need have [`node 20`](https://nodejs.org/en/) installed and then enable [`corepack`](https://nodejs.org/api/corepack.html):

```bash
corepack enable
Expand Down Expand Up @@ -108,6 +108,8 @@ periodically triggers the deployment.
- `pnpm run create-post` prompts to generate new posts
- `pnpm run preview` starts a server that serves the content of `dist/`
- `pnpm run pre-commit` runs automatically on pre-commit; there's no need to call it directly
- `pnpm run test` runs tests
- `pnpm run test:watch` runs tests in watch mode

## Designs

Expand Down
10 changes: 7 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,15 @@
"create-post": "node scripts/create-post.mjs",
"preview": "astro preview",
"fmt": "prettier . --write",
"test": "vitest --run",
"test:watch": "vitest --watch",
"prepare": "husky install; pnpm run astro:sync",
"pre-commit": "lint-staged"
},
"engines": {
"node": "^18.17.0"
"node": "^20.10.0"
},
"packageManager": "pnpm@8.14.1",
"packageManager": "pnpm@8.15.4",
"devDependencies": {
"@astrojs/rss": "^4.0.1",
"@astrojs/sitemap": "^3.0.3",
Expand All @@ -34,12 +36,14 @@
"astro-i18next": "1.0.0-beta.21",
"chalk": "^5.0.1",
"husky": "^8.0.0",
"jsdom": "^24.0.0",
"lint-staged": "^13.0.3",
"mustache": "^4.2.0",
"prettier": "2.7.1",
"prompts": "^2.4.2",
"sass": "^1.65.1",
"tiny-invariant": "^1.2.0"
"tiny-invariant": "^1.2.0",
"vitest": "^1.3.1"
},
"dependencies": {
"@fontsource/open-sans": "^4.5.11",
Expand Down
Loading
Loading