fix/GH-70 upcoming events page issue #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other changes: - update settings.json
✅ Deploy Preview for romajs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
gdorsi
approved these changes
Mar 9, 2024
| return (scheduledEvents as UpcomingEvent[]) | ||
| .concat(placeholderEvents) | ||
| .sort((a, b) => a.epochTimeMs - b.epochTimeMs); | ||
| } |
There was a problem hiding this comment.
Looks like the logic is starting to be complex enough to justify some tests.
Do you have opinions about it?
If you agree I can start by creating an issue
There was a problem hiding this comment.
- Added vitest as test runner.
- Tests now run on CI.
- added meetup-events.test.ts tests.
| </li> | ||
| )} | ||
| </Show> | ||
| </> |
There was a problem hiding this comment.
This component is becoming a bit hard to read.
How do you feel about splitting in multiple components?
There was a problem hiding this comment.
done in feb1a5c
Other changes: - add vitest as test runner - run tests on CI
gdorsi
approved these changes
Mar 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #70
Other changes