Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better text color selection for a given background #820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Text color selection for given background now takes into account huma…
…n perception.
kosumosu committed Nov 29, 2024
commit d77556e867b9c724833e98df6d6531b86ea02d15
2 changes: 1 addition & 1 deletion src/utils.ts
Original file line number Diff line number Diff line change
@@ -112,7 +112,7 @@ export function computeColor(color: string): string {

export function computeTextColor(backgroundColor: string): string {
const colorObj = new TinyColor(backgroundColor);
if (colorObj.isValid && colorObj.getLuminance() > 0.5) {
if (colorObj.isValid && colorObj.isLight()) {
return '#000'; // bright colors - black font
} else {
return '#fff'; // dark colors - white font