Better text color selection for a given background #820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, apexcharts selects text color inadequately. It can select white text for quiet bright background.
The problem is that
computeTextColor()
function uses linearcolorObj.getLuminance()
, which is not how human percepts color.TinyColor has
isLight()
/isDark()
methods, which work in gamma space, and my experiments indicate it works better for this purpose.Here is the comparison (before/after):
The color of the graph is
#BAACC7
which has linear luminance of about 0.44. This is less than 0.5, thus master version of apex-charts selects white text color. However, as you can probably see, black text color is much more readable.