Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Rail Buttons Not Accepted in Add Surfaces #701

Merged
merged 10 commits into from
Oct 9, 2024

Conversation

MateusStano
Copy link
Member

In v1.6.0 rail buttons are no longer accepted in the add_surfaces method of the rocket class. This PR reintroduces this functionality as to avoid breaking changes

This was unfortunately something added in previous versions. Rail buttons do not behave like aerodynamic surfaces and should not be grouped together with them. A rocket can only have one set of rail buttons, this is why we have a set_rail_buttons and not a add_rail_buttons method.

Tests are passing locally

@MateusStano MateusStano requested a review from a team as a code owner October 3, 2024 11:58
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG needs to be updated!!! Is the develop branch already updated from master?

Please wait for the tests to be all checked.

We should pack a new release soon.

@Gui-FernandesBR Gui-FernandesBR changed the base branch from develop to dep/remove-noaas-ruc-sounding October 9, 2024 01:52
@Gui-FernandesBR Gui-FernandesBR force-pushed the bug/buttons-not-in-add-surfaces branch from dfcf2d8 to 565e6a7 Compare October 9, 2024 01:52
Base automatically changed from dep/remove-noaas-ruc-sounding to develop October 9, 2024 02:01
@Gui-FernandesBR
Copy link
Member

LGTM

@Gui-FernandesBR Gui-FernandesBR merged commit fea6bfc into develop Oct 9, 2024
5 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the bug/buttons-not-in-add-surfaces branch October 9, 2024 02:07
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.90%. Comparing base (b9b44dd) to head (4090d97).
Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
rocketpy/rocket/rocket.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #701      +/-   ##
===========================================
- Coverage    76.02%   75.90%   -0.13%     
===========================================
  Files           99       99              
  Lines        11278    11220      -58     
===========================================
- Hits          8574     8516      -58     
  Misses        2704     2704              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants