-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Rail Buttons Not Accepted in Add Surfaces #701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CHANGELOG needs to be updated!!! Is the develop branch already updated from master?
Please wait for the tests to be all checked.
We should pack a new release soon.
dfcf2d8
to
565e6a7
Compare
LGTM |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #701 +/- ##
===========================================
- Coverage 76.02% 75.90% -0.13%
===========================================
Files 99 99
Lines 11278 11220 -58
===========================================
- Hits 8574 8516 -58
Misses 2704 2704 ☔ View full report in Codecov by Sentry. |
…cketPy-Team/RocketPy into dep/remove-noaas-ruc-sounding
In v1.6.0 rail buttons are no longer accepted in the
add_surfaces
method of the rocket class. This PR reintroduces this functionality as to avoid breaking changesThis was unfortunately something added in previous versions. Rail buttons do not behave like aerodynamic surfaces and should not be grouped together with them. A rocket can only have one set of rail buttons, this is why we have a
set_rail_buttons
and not aadd_rail_buttons
method.Tests are passing locally