-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: delete tools.cached_property (fix #531) #541
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #541 +/- ##
==========================================
- Coverage 71.23% 71.21% -0.03%
==========================================
Files 55 55
Lines 9259 9242 -17
==========================================
- Hits 6596 6582 -14
+ Misses 2663 2660 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
try: | ||
from functools import cached_property | ||
except ImportError: | ||
from ..tools import cached_property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is trying to merge directly into the master branch. This needs to be changed to merge into develop instead. I think the easiest solution is the cherry picking now: https://stackoverflow.com/questions/36055622/how-to-change-base-branch-in-git It's important to follow the git flow correctly so we an easily navigate through our git tree in the future. Therefore, only hotfixes and releases should be merged directly to the master branch. New features needs to pass through the |
1 similar comment
This PR is trying to merge directly into the master branch. This needs to be changed to merge into develop instead. I think the easiest solution is the cherry picking now: https://stackoverflow.com/questions/36055622/how-to-change-base-branch-in-git It's important to follow the git flow correctly so we an easily navigate through our git tree in the future. Therefore, only hotfixes and releases should be merged directly to the master branch. New features needs to pass through the |
Renamed the PR to make it easier for us. |
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest --runslow
) have passed locallyCurrent behavior
Issue 531, current behavior doesn't change too much
New behavior
Issue 531, current behavior doesn't change too much
Breaking change
Additional information
Enter text here...