Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: delete tools.cached_property #531

Closed
2 tasks done
Gui-FernandesBR opened this issue Jan 14, 2024 · 0 comments · Fixed by #587
Closed
2 tasks done

MNT: delete tools.cached_property #531

Gui-FernandesBR opened this issue Jan 14, 2024 · 0 comments · Fixed by #587
Assignees
Labels

Comments

@Gui-FernandesBR
Copy link
Member

Gui-FernandesBR commented Jan 14, 2024

Is your feature request related to a problem? Please describe.

Since we no longer support python 3.7, we don't need to keep our own implementation of the cached_property decorator.

Describe the solution you'd like

  • Delete the cached_property definition inside the tools.py module.
  • Adjust all the imports throughout the rocketpy module

In order to avoid breaking changes, I think we could import the cached_property in the tools.py module so it doesn't break when we do from rocketpy.tools import cached_property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
2 participants