-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: workflows update and new docker files #448
Conversation
it would be nice if we fix (or simply delete) the action that makes actions fail if the PR is marked as draft. What is the point of not applying tests on the draft PRs?
|
Example of project that also uses Dockerfile: https://github.com/pandas-dev/pandas/blob/main/Dockerfile Thanks @phmbressan for mentioning this today. |
FYI: you can try https://github.com/ringsaturn/tzfpy under Python 3.12 before timezonefinder is ready for it. |
This is important because the github actions were not being activated after modifying the .yaml files
Tests are passing on Python 3.12 (good news!!). Several deprecation warnings are being raised tho, let's take a look at those in the next weeks. |
Thank you for your suggestion, your project is very nice. We will take a deeper look in the future. |
MNT: add codecov integration
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #448 +/- ##
=========================================
Coverage ? 69.54%
=========================================
Files ? 56
Lines ? 8868
Branches ? 0
=========================================
Hits ? 6167
Misses ? 2701
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest --runslow
) have passed locallyCurrent behavior
New behavior
Dockerfile
and adocker-compose.yml
file to build and run rocketpy in Docker containers.Breaking change
Additional information
timezonefinder
can not be installed yet (see Python 3.12 compatibility jannikmi/timezonefinder#208)