MNT: update develop branch with changes from master #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This happens when we use EmptyMotors - ValueError: attempt to get argmax of an empty sequence
BUG: flight.prints.max_values() fails when launching an EmptyMotor
DOC: Add documentation on how to build the docs
Co-authored-by: MateusStano <[email protected]>
Co-authored-by: MateusStano <[email protected]>
Co-authored-by: MateusStano <[email protected]>
This is important because the github actions were not being activated after modifying the .yaml files
- Refined input parameters for apogee and liftoff speed calculations - Inertia definition in the Rocket class - Change the Motor.dry_mass definition - Avoid repetition of dry_mass definitions - Add a few for docstrings
parameter as in Motor class
DOCs: improve mass and inertia docs
|
I believe #451 could be merged into develop and be released with v1.1.0. I wouldn't call it a major bug that requires a hot fix, since the current behavior is documented. |
That will be released with v1.1.0 anyways, regardless of the head branch, we decided to not have a v1.0.2 version |
|
@Gui-FernandesBR, I strongly believe we should follow the appropriate protocols here. Since there is no hotfix necessary, all code additions (i.e. not just doc changes) should go directly to develop before master. |
MNT: add codecov integration
ENH: workflows update and new docker files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCurrent behavior
I'm opening this PR as a reminder that we need to rebase the develop branch before preparing the release v1.1.0 this week.
New behavior
There are 3 PR waiting on the line to be merged on master. We need to wait for them before merging this PR.
Conflicts may be solved after the 3 PR please.
Breaking change
Additional information
This can only be merged after approved.