Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Remove NoseCone Warning #428

Merged
merged 4 commits into from
Oct 7, 2023
Merged

BUG: Remove NoseCone Warning #428

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1606bbd
Merge pull request #417 from RocketPy-Team/maint/reinstate-develop
phmbressan Sep 23, 2023
41bb0ac
Merge pull request #421 from RocketPy-Team/master
phmbressan Sep 27, 2023
76b8784
BUG: print length warning only when needed
MateusStano Oct 6, 2023
5362247
BUG: change order of print and length set
MateusStano Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions rocketpy/rocket/aero_surface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from abc import ABC, abstractmethod
import warnings

import matplotlib.pyplot as plt
import numpy as np
from scipy.optimize import fsolve

Expand Down Expand Up @@ -426,12 +425,13 @@ def final_shape(x):

# Evaluate final geometry parameters
self.shape_vec = [nosecone_x, nosecone_y]
self._length = nosecone_x[-1]
print(
"Due to the chosen bluffness ratio, the nose cone length was reduced to {:.3f} m.".format(
self.length
if abs(nosecone_x[-1] - self.length) >= 0.001: # 1 milimiter
self._length = nosecone_x[-1]
print(
"Due to the chosen bluffness ratio, the nose cone length was reduced to m.".format(
self.length
)
)
)
self.fineness_ratio = self.length / (2 * self.base_radius)

return None
Expand Down
Loading