Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Remove NoseCone Warning #428

Merged
merged 4 commits into from
Oct 7, 2023
Merged

BUG: Remove NoseCone Warning #428

merged 4 commits into from
Oct 7, 2023

Conversation

MateusStano
Copy link
Member

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest --runslow) have passed locally

Current behavior

When defining a NoseCone a message is printed saying that the nosecone length has changed due to bluffness, even when it has no bluffness

New behavior

Now the print is only done when an effective change has been made

Breaking change

  • Yes
  • No

Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done here

@Gui-FernandesBR
Copy link
Member

BUG fixes.
Those should go directly to the master branch, right?

@MateusStano MateusStano changed the base branch from develop to master October 7, 2023 16:38
@MateusStano MateusStano merged commit 92922c6 into master Oct 7, 2023
9 checks passed
@MateusStano MateusStano deleted the bug/nosecone-print branch October 7, 2023 16:39
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants