Rewrote the Entire Control System (and command flow) 😎 ✌️ #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and also added value for trackwidth
…04/standard into splines-test-2023
use wpilibj2's CommandXBoxController instead
would fix it but blocked by SensorDrive usage of NavX instead of IMU
remove AbstractMotor, reminder to use 4904 custom MotorController interface
renamed BrakeableMotor to BrakeableMotorController for consistency with MotorController MotorBrake deleted, use Commands.runOnce(BrakeableMotorSubsystem.setBrakeOnNeutral) instead besides, you probably actually want BrakeableMotorSubsystem.c_brake()
wpilib says that for setVoltage, you have to keep calling it => remove the commands that don't keep calling it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lol
lmao even