Arm auton edits #23
Open
Arm auton edits #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Driver Code to Auton Branch
added 2 commits
March 8, 2018 17:42
Codadillo
commented
Mar 10, 2018
|
|
||
| public class RobotMap { | ||
| public static class Port { | ||
|
|
||
| public static class Port { // TODO: Correct Ports |
There was a problem hiding this comment.
This should have the correct ports. Either that or this comment shouldn't be here.
| @@ -66,11 +74,12 @@ | |||
| public static final double INCHES_PER_TICK = Metrics.Wheel.CIRCUMFERENCE_INCHES | |||
| / Metrics.Wheel.TICKS_PER_REVOLUTION; | |||
| } | |||
| public static final double LENGTH = 32.75; | |||
| public static final double WIDTH = 27.75; | |||
| public static final double LENGTH = 49.04;// 32.75; | |||
| @@ -83,15 +92,20 @@ | |||
| public static TankDriveShifting chassis; | |||
| public static Motor leftWheel; | |||
| public static Motor rightWheel; | |||
| public static DiscBrake discBrake; | |||
| public static NavX navx; | ||
| public static Subsystem[] mainSubsystems; |
There was a problem hiding this comment.
this shouldn't be merged until shuffleboard is merged
| @@ -0,0 +1,33 @@ | |||
| package org.usfirst.frc4904.robot.commands; | |||
| import edu.wpi.first.wpilibj.command.CommandGroup; | ||
|
|
||
| /** | ||
| * |
There was a problem hiding this comment.
This should be a proper javadocs.
Codadillo
commented
Mar 10, 2018
| * piston and stopping the arm. | ||
| * | ||
| */ | ||
| public class ArmSet extends CommandGroup { |
There was a problem hiding this comment.
Isn't this command the exact same thing as ArmMove, but with a different name? Do we need this?
|
|
||
|
|
||
| /* | ||
| * ArmSet is similar to MotorPositionConstant |
There was a problem hiding this comment.
This isn't ArmSet, this is ArmMove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge changes that were made to the intake, arm, and indexer during auton testing.