[solvers] Change solver names to upstream's preferred case #22407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: high
release notes: fix
|
+@hongkai-dai for review, please? |
hongkai-dai
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Reviewable status: LGTM missing from assignee ggould-tri(platform)
jwnimmer-tri
force-pushed
the
mosek-solver-id-name
branch
from
ddb95a4 to
87a145e
Compare
Clp prefers camel. Ipopt prefers camel. MOSEK prefers scream.
jwnimmer-tri
force-pushed
the
mosek-solver-id-name
branch
from
87a145e to
836db23
Compare
jwnimmer-tri
commented
Jan 7, 2025
There was a problem hiding this comment.
@hongkai-dai Russ found some more mis-named solvers. I've pushed them here, so PTAL.
Reviewable status: LGTM missing from assignee ggould-tri(platform)
ggould-tri
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees ggould-tri(platform),hongkai-dai
jwnimmer-tri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream prefers the scream case (https://www.mosek.com/products/mosek/).
Towards #20967.
This change is