Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep capacity sane when creating a bitmap with a capacity #499

Merged
merged 2 commits into from
Aug 5, 2023
Merged

Keep capacity sane when creating a bitmap with a capacity #499

merged 2 commits into from
Aug 5, 2023

Commits on Aug 5, 2023

  1. Keep capacity sane when creating a bitmap with a capacity 

    The previous code would happily accept and create _huge_ allocations
(up to 22 GiB) for up to 2 billion containers. However, we know the maximum
number of containers possible, so we instead clamp to that value.

This leads to two changes:
- When requesting more than 2^16 containers, we will only allocate space for
  2^16 containers
- When requesting more than 2^31 containers, we will no longer error
    @Dr-Emann
    Dr-Emann committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    d48f461 View commit details
    Browse the repository at this point in the history

  2. Add a unit test that we allow huge capacities

    @Dr-Emann
    Dr-Emann committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    04740dc View commit details
    Browse the repository at this point in the history