Keep capacity sane when creating a bitmap with a capacity #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code would happily accept and create _huge_ allocations (up to 22 GiB) for up to 2 billion containers. However, we know the maximum number of containers possible, so we instead clamp to that value. This leads to two changes: - When requesting more than 2^16 containers, we will only allocate space for 2^16 containers - When requesting more than 2^31 containers, we will no longer error
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code would happily accept and create huge allocations (up to 22 GiB) for up to 2 billion containers. However, we know the maximum number of containers possible, so we instead clamp to that value.
This leads to two changes: