Revert change to .gitignore.d behavior in #196 #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes RichiH#333. In git 2.7.0, new git behavior changed gitignore to no longer require un-ignoring every parent directory above an un-ignored file. vcsh updated its logic around this in PR RichiH#196 (vcsh commit e4f4ecf). Unfortunately, git's change was reverted before 2.8.0-rc4 (git commit 5cee349). This change therefore reverts the logic change in RichiH#196 causing `vcsh write-gitignore` to once again emit parent directories into generated `.gitignore.d/<repo>` files. See RichiH#333 for the gory details.
|
FWIW, I opted to leave the code that gets git's version info, but that's now dead code so there's an argument to remove it as well. |
|
The editorconfig lint check appears to have failed because it's looking inside the |
jwhitley
added a commit
to jwhitley/vcsh-root
that referenced
this pull request
Dec 28, 2023
jwhitley
changed the title
|
Confirmed. Looks like an update to the editorconfig checker Docker image is required, to >=2.7.1. Might as well bump to latest release of 2.7.2. See editorconfig-checker/editorconfig-checker#268 |
alerque
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #333.
In git 2.7.0, new git behavior changed gitignore to no longer require un-ignoring every parent directory above an un-ignored file. vcsh updated its logic around this in PR #196 (e4f4ecf). Unfortunately, git's change was reverted before 2.8.0-rc4 (git/git@5cee349).
This change therefore reverts the logic change in #196 causing
vcsh write-gitignoreto once again emit parent directories into generated.gitignore.d/<repo>files.See #333 for the gory details.