Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs failing lint checks b/c editorconfig-checker upgrade required #335

Closed
jwhitley opened this issue Dec 29, 2023 · 1 comment
Closed

PRs failing lint checks b/c editorconfig-checker upgrade required #335

jwhitley opened this issue Dec 29, 2023 · 1 comment

Comments

@jwhitley
Copy link
Contributor

[Lifting this to its own issue so it doesn't get lost. –J]

As noted in my comments on #334, editorconfig-checker is failing its lint check on the PR CI runs because it's scanning inside the .git directory and throwing a bunch of bogus errors as a result. An update to the editorconfig checker Docker image is required, to >=2.7.1. Might as well bump to latest release of 2.7.2. See editorconfig-checker/editorconfig-checker#268 for details.

@alerque
Copy link
Collaborator

alerque commented Dec 29, 2023

Fixed in 937022f.

Hopefully the bump to release artifact tooling doesn't mess up our next release. I looked everything over for relevant changes but without trying it isn't always clear what might have broken when bumping these Actions.

@alerque alerque closed this as completed Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants