Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shimada tungsten permeability 2019 #274

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

RemDelaporteMathurin
Copy link
Owner

This PR adds a new tungsten permeability (T) from Shimada 2019.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (44368b1) to head (c3db0d8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files          76       76           
  Lines        1806     1807    +1     
=======================================
+ Hits         1783     1784    +1     
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin
Copy link
Owner Author

@FuerstT would you mind reviewing this?

Masa provided experimental data points but I did not include them 😄

Comment on lines 2625 to 2641
@article{shimada_tritium_2018,
title = {Tritium permeability measurement in hydrogen-tritium system},
volume = {129},
issn = {0920-3796},
url = {https://www.sciencedirect.com/science/article/pii/S0920379618301340},
doi = {10.1016/j.fusengdes.2018.02.033},
abstract = {Understanding of thermodynamic equilibria of multi-components hydrogen isotopes is required to accurately measure tritium permeability at the expected low tritium partial pressure and non-negligible high hydrogen partial pressure in a fusion blanket system. A gas-driven tritium permeation system that is capable of independently controlling hydrogen and tritium partial pressures was developed at Idaho National Laboratory to accurately measure low partial pressure tritium permeability. The thermodynamic equilibria for hydrogen (H) – tritium (T) permeation through metal are discussed to accurately measure tritium permeability, and the experimental conditions required for evaluating tritium permeability in H-T system are presented.},
language = {en},
urldate = {2022-04-28},
journal = {Fusion Engineering and Design},
author = {Shimada, M. and Pawelko, R. J.},
month = apr,
year = {2018},
keywords = {Hydrogen, Permeation, Tritium, Blanket, Reduced activation ferritic/martensitic steel},
pages = {134--139},
file = {ScienceDirect Full Text PDF:C\:\\Users\\remidm\\Zotero\\storage\\2GMYKNEK\\Shimada et Pawelko - 2018 - Tritium permeability measurement in hydrogen-triti.pdf:application/pdf;ScienceDirect Snapshot:C\:\\Users\\remidm\\Zotero\\storage\\ZK9KBPN2\\S0920379618301340.html:text/html},
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the right reference? this paper seems to refer to reduced activation steels rather than tungsten. Although we could add these too

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, let me check

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@jhdark jhdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RemDelaporteMathurin RemDelaporteMathurin merged commit 7c29506 into main Mar 26, 2024
9 checks passed
@RemDelaporteMathurin RemDelaporteMathurin deleted the shimada_permeability_tungsten branch March 26, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants