Adds Settings Dialog #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrPaulSharp
force-pushed
the
settings
branch
from
0e387ad to
76df976
Compare
DrPaulSharp
force-pushed
the
settings
branch
4 times, most recently
from
729d7e8 to
219821b
Compare
StephenNneji
approved these changes
Oct 2, 2024
| @@ -22,6 +22,26 @@ def get_global_settings() -> QtCore.QSettings: | |||
| ) | |||
|
|
|||
|
|
|||
| def delete_local_settings(path: str | PathLike) -> None: | |||
There was a problem hiding this comment.
I feel like this should be in the Setting class with a catchy name like delete_cache or something
There was a problem hiding this comment.
Hmm, I was thinking about this, but does the settings file correspond with a particular instance of the Settings object? (The save routine is in the object as well though so . . .)
There was a problem hiding this comment.
Yes it does, we are just saving to the same place so it may not seem that way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
This PR introduces a settings dialog, with tabs mapped to the settings groups established in the settings model. Project settings are updated with any changes made, excluding resetting to the global default.
This PR also addresses a bug in the code in that menu actions affecting a project were all enabled (unlike the taskbar which was correctly disabled), causing the GUI to crash in some cases. The appropriate menu actions have been disabled on startup.