Skip to content

Commit

Permalink
Removes logging tab
Browse files Browse the repository at this point in the history
  • Loading branch information
DrPaulSharp committed Oct 2, 2024
1 parent dde7616 commit 729d7e8
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
1 change: 0 additions & 1 deletion rascal2/dialogs/settings_dialog.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ def __init__(self, parent):

tab_widget = QtWidgets.QTabWidget()
tab_widget.addTab(SettingsTab(self, SettingsGroups.General), SettingsGroups.General)
tab_widget.addTab(SettingsTab(self, SettingsGroups.Logging), SettingsGroups.Logging)

self.reset_button = QtWidgets.QPushButton("Reset to Defaults", self)
self.reset_button.clicked.connect(self.reset_default_settings)
Expand Down
4 changes: 1 addition & 3 deletions tests/test_dialogs.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import pytest
from PyQt6 import QtCore, QtWidgets

from rascal2.core.settings import LogLevels, Settings, SettingsGroups
from rascal2.core.settings import Settings, SettingsGroups
from rascal2.dialogs.project_dialog import ProjectDialog
from rascal2.dialogs.settings_dialog import SettingsDialog, SettingsTab
from rascal2.widgets.inputs import ValidatedInputWidget
Expand Down Expand Up @@ -211,7 +211,6 @@ def test_settings_dialog_reset_button(settings_dialog_with_parent):
"tab_group, settings_labels",
[
(SettingsGroups.General, ["Style", "Editor Fontsize", "Terminal Fontsize"]),
(SettingsGroups.Logging, ["Log Path", "Log Level"]),
],
)
def test_settings_dialog_tabs(settings_dialog_with_parent, tab_group, settings_labels):
Expand All @@ -236,7 +235,6 @@ def test_settings_dialog_tabs(settings_dialog_with_parent, tab_group, settings_l
[
# Test for non-default style later, when another is added
(SettingsGroups.General, {"style": "light", "editor_fontsize": 5, "terminal_fontsize": 5}),
(SettingsGroups.Logging, {"log_path": "test_path/test.log", "log_level": LogLevels.Debug}),
],
)
def test_settings_dialog_widgets(settings_dialog_with_parent, tab_group, test_values):
Expand Down

0 comments on commit 729d7e8

Please sign in to comment.