Added conclave directory with README explaining this fork

[shamsasari]

No description provided.

[ac101m]

Would it maybe make sense to keep the original readme and just have an additional one for conclave? Now that I think about it, maybe it makes sense to put all of our stuff in it's own directory within the repository.

[shamsasari]

Would it maybe make sense to keep the original readme and just have an additional one for conclave?

The problem then becomes discovery. How does someone new learn how this repo works without being told to open a particular file?

Now that I think about it, maybe it makes sense to put all of our stuff in it's own directory within the repository.

That's the plan. All of the contents of the graal dir in the SDK would be moved to conclave here.

[bon000]

Minor comments

[shamsasari]

The patch itself has been applied in a separate PR: #1

[shamsasari]

"Upstream" seems to be standard way to refer to the repo that was forked: https://stackoverflow.com/questions/2739376/definition-of-downstream-and-upstream.

[bon000]

"Upstream" seems to be standard way to refer to the repo that was forked: https://stackoverflow.com/questions/2739376/definition-of-downstream-and-upstream.
Never heard of that, not a blocker from my side, just wondering if this was confusing.
The fact that more than 1k people have voted for that question on Stack Overflow make me think that too many people have searched for that and maybe another terminology could have been used.

[shamsasari]

Comments addressed.

[filipesoliveira]

The patch itself has been applied in a separate PR: #1

I am not sure why we are doing that. What is the plan to merge graal to repository? Are you doing that as part of another PR?

[ac101m]

The problem then becomes discovery. How does someone new learn how this repo works without being told to open a particular file?

I'd suggest dropping a one-two sentence description at the top of the existing readme, and also a link to a readme in the conclave directory.

[shamsasari]

I am not sure why we are doing that.

Purely to have a separate commit in the git history with just our changes.

What is the plan to merge graal to repository? Are you doing that as part of another PR?

I'm not sure what you mean here. But if you're referring to the graal dir in the SDK, then yes the plan is to move that here into a new conclave directory.

[shamsasari]

@ac101m I like your suggestion. Done.