Apply patch from SDK #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markers have been added around each modification to make it easier to track our changes when merge conflicts with upstream occur.
shamsasari
force-pushed
the
shams-apply-patch
branch
from
3828080
to
c9dd18a
Compare
Whoops, didn't notice this was still WIP. |
|
This will merge after #2 |
|
It looks OK. |
|
Just updated the patch with |
|
LGTM. |
|
@filipesoliveira in the standup we said that we would commit the patch to the repo. Just to be clear, we're not committing the actual patch file, but applying the diff as a PR here. Sorry for the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markers have been added around each modification to make it easier to track our changes when merge conflicts with upstream occur.