Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some EditGameRulesScreen and GameRules mappings for accuracy and consistency #488

Merged
merged 15 commits into from
Sep 12, 2023
Merged

Update some EditGameRulesScreen and GameRules mappings for accuracy and consistency #488

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f48fdef
GameRules mapping changes for consistency
Antikyth Sep 6, 2023
573f161
EditGameRulesScreen changes for accuracy and consistency
Antikyth Sep 6, 2023
00eff4e
a couple missed `name`s and `rule`s
Antikyth Sep 6, 2023
0670426
fill in game rule and category names
Antikyth Sep 6, 2023
1e40a85
fix game rule javadoc references
Antikyth Sep 6, 2023
4289e2f
clarify GameRules.Visitor method names
Antikyth Sep 6, 2023
57fb928
rename GameRules.Acceptor.call to accept
Antikyth Sep 6, 2023
d8c1703
fix GameRules.Visitor javadoc references
Antikyth Sep 6, 2023
0b617ac
fix and edit GameRules#accept javadocs
Antikyth Sep 6, 2023
98f1cb3
rename more rule names to game rule in GameRules
Antikyth Sep 6, 2023
77c1878
rename GameRules.get{Int, Boolean} to get{Int, Boolean}GameRuleValue
Antikyth Sep 6, 2023
8b38065
Apply suggestions from code review
Antikyth Sep 7, 2023
5cad23c
GameRules.get{Int,Boolean}GameRuleValue -> get{Int,Boolean}Value
Antikyth Sep 7, 2023
bb7eaa1
Merge branch '1.20.2-pre2' into game-rules
Antikyth Sep 8, 2023
f51c622
drop invalid mappings
ix0rai Sep 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mappings/net/minecraft/world/GameRules.mapping
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ CLASS net/minecraft/unmapped/C_xmldumst net/minecraft/world/GameRules
ARG 1 key
ARG 2 type
CLASS C_bctfwntr Acceptor
METHOD call call (Lnet/minecraft/unmapped/C_xmldumst$C_avotqrag;Lnet/minecraft/unmapped/C_xmldumst$C_iuaedxxw;Lnet/minecraft/unmapped/C_xmldumst$C_mymgluou;)V
METHOD call accept (Lnet/minecraft/unmapped/C_xmldumst$C_avotqrag;Lnet/minecraft/unmapped/C_xmldumst$C_iuaedxxw;Lnet/minecraft/unmapped/C_xmldumst$C_mymgluou;)V
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All methods that call this are named accept, and it is the only thing in the class called Acceptor.

Antikyth marked this conversation as resolved.
Show resolved Hide resolved
ARG 1 consumer
ARG 2 key
ARG 3 type
Expand Down
Loading