Update some EditGameRulesScreen and GameRules mappings for accuracy and consistency

[Antikyth]

This PR changes existing mappings in EditGameRulesScreen and GameRules.

EditGameRulesScreen

• RuleListWidget -> GameRuleEntryListWidget
  • In line with other widgets extending EntryListWidget.
  • Rule changed to GameRule for consistency: I found it confusing when reading code and seeing game rules variously referred to as rules or game rules.
• occurrences of name -> message
  • This is to reduce confusion between the "technical name", as seen in GameRules.Key.getName(), and the message shown in GUIs.
  • message chosen based on the name used in buttons.
• occurrences of description -> tooltip
  • These actually refer to the tooltip.
• occurrences of ruleName -> description
  • These actually refer to the description.
• occurrences of rule -> gameRule
  • For consistency, as above.
• AbstractRuleWidget -> AbstractEntry
  • Entry is for consistency with other classes extending EntryListWidget.
  • Called AbstractEntry rather than AbstractGameRuleEntry because it is also used for categories.
• NamedRuleWidget -> GameRuleEntry
  • This is what the actual game rule entries extend.
• RuleCategoryWidget -> CategoryEntry
  • name -> title
    • matches its narration

GameRules

• added the names for all the game rules and categories: it's just the string names in WHATEVER_THIS_CASE_IS case.
• Rule -> AbstractGameRule
  • This is an abstract class extended by the boolean and int game rule classes.
• In general, rule -> game rule
  • For consistency, as previously mentioned.

Category

• category, getCategory -> translationKey, getTranslationKey
  • As you can imagine, these actually refer to the translation key.

[ix0rai]

fantastic once again!
the detailed descriptions are amazing to have, I hardly needed to skim the diff to review this :)

[Antikyth]

Note that these have been swapped as well. The method's parameters are indeed GuiGraphics graphics, int y, int x. I assume it's a mistake. But they are used within the method, which is how you can tell:

protected void drawMessage(GuiGraphics graphics, int y, int x) {
    if (this.name.size() == 1) {
        graphics.drawText(EditGameRulesScreen.this.client.textRenderer, (OrderedText)this.name.get(0), x, y + 5, 16777215, false);
    } else if (this.name.size() >= 2) {
        graphics.drawText(EditGameRulesScreen.this.client.textRenderer, (OrderedText)this.name.get(0), x, y, 16777215, false);
        graphics.drawText(EditGameRulesScreen.this.client.textRenderer, (OrderedText)this.name.get(1), x, y + 10, 16777215, false);
    }
}

See how the x and y are used in the drawText calls. The y is shifted based on whether there is one or two lines of text.

[Antikyth]

This is a lambda function:

map.entrySet()
    .stream()
    .sorted(Map.Entry.comparingByKey())
    .forEach(categoryMapEntry -> {
        this.addEntry(
            EditGameRulesScreen.this.new CategoryEntry(
                Text.translatable(((GameRules.Category) categoryMapEntry.getKey()).getTranslationKey()).formatted(Formatting.BOLD, Formatting.YELLOW)
            )
        );
        ((Map) categoryMapEntry.getValue())
            .entrySet()
            .stream()
            .sorted(Map.Entry.comparingByKey(Comparator.comparing(GameRules.Key::getName)))
            .forEach(gameRuleMapEntry -> this.addEntry((AbstractEntry) gameRuleMapEntry.getValue()));
    });

[Antikyth]

map is of type Map<GameRules.Category, Map<GameRules.Key<?>, AbstractEntry>>.
categoryMapEntry is of type Map.Entry<GameRules.Category, Map<GameRules.Key<?>, AbstractEntry>>.
gameRuleMapEntry is of type Map.Entry<GameRules.Key<?>, AbstractEntry>.

[Antikyth]

All methods that call this are named accept, and it is the only thing in the class called Acceptor.

[Antikyth]

I thought it was confusing that these are named visitInt and visitBoolean when they don't visit ints or booleans but rather IntGameRules and BooleanGameRules.

[Antikyth]

I already fixed those javadocs. It needs to be rebuilt.

[EnnuiL]

After looking more deeply into the CI error, I can see there are still few (one...?) Javadoc reference errors, with an attempted reference to Visitor#visit (renamed to Visitor#visitGameRule) being the cause

[Antikyth]

After looking more deeply into the CI error, I can see there are still few (one...?) Javadoc reference errors, with an attempted reference to Visitor#visit (renamed to Visitor#visitGameRule) being the cause

Ah, sorry. I see now. It looked a lot like the javadoc I'd already fixed.

[Antikyth]

Also, I think visit would have been a better name, but because there are ones for visiting booleans and int game rules as well, I think it needs game rule on the end to not be confusing.

[EnnuiL]

Looks good to me!

[github-actions]

🚨 Target branch is already set to 23w35a

[github-actions]

🚀 Target branch has been updated to 1.20.2-pre2

[github-actions]

🚨 Please fix merge conflicts before this can be merged

[Antikyth]

Oh boy I love me some merge conflicts /s