-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further development of Fock states #69
Conversation
@Krastanov you might disagree with the following changes, which is OK and we can discuss them:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 72.94% 74.65% +1.70%
==========================================
Files 18 19 +1
Lines 791 789 -2
==========================================
+ Hits 577 589 +12
+ Misses 214 200 -14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a bunch of questions related to some of the details of how numerical expressions happen. I think I prefer we follow different semantics for the cutoff. Let's consider these notes as a first round of discussion on the topic.
…on-working example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty good. I have the following requests:
- bring back the warning on default cutoff
- make the cutoff a keyword arg in the constructor (to make it easy to extend in the future)
- remove one of the exports
- check whether the naming change affects QuantumSavory and make sure the breaking change is mentioned in a changelong and an appropriate version bump is made
Feel free to merge without another review after this is done.
let me know if I am missing something that is making the requests unreasonable |
All of your requests sound good to me. @Krastanov Edit: actually, there's one small issue related to the first request, which I mentioned earlier in the first round of review:
|
ah, noted! Sounds good, let's keep it as a warning to the docs for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree to the plan about adding a warning to the docs.
@Krastanov copying this down below: in your commit you modified |
My bad. I meant kwarg. Maybe with |
predefined.jl
to a new filepredefined_fock.jl
.DisplaceOp
andPhaseShiftOp
, respectively.express
functionality for Fock objects.