Fix shape inference for Loop #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neNasko1
requested review from
adityagoel4512,
cbourjau and
jbachurski
as code owners
adityagoel4512
requested changes
Jan 3, 2025
adityagoel4512
requested changes
Jan 3, 2025
1 task
neNasko1
changed the title
|
Note, that this does not run the test actions, so we should wait before merging. |
adityagoel4512
previously approved these changes
Jan 3, 2025
adityagoel4512
dismissed
their stale review
This is provisionally approved but I'll reapprove once the test action is fixed.
Fix inconsistencies Signed-off-by: neNasko1 <[email protected]> Add CHANGELOG Signed-off-by: neNasko1 <[email protected]> Fix docstring Signed-off-by: neNasko1 <[email protected]> Apply suggestions from code review Co-authored-by: Aditya Goel <[email protected]> Comments after code review Signed-off-by: neNasko1 <[email protected]> Comments after code review Signed-off-by: neNasko1 <[email protected]> Fix license Signed-off-by: neNasko1 <[email protected]>
neNasko1
force-pushed
the
loop-inference
branch
from
a3a8723 to
561a01f
Compare
Signed-off-by: neNasko1 <[email protected]>
adityagoel4512
approved these changes
Jan 3, 2025
Co-authored-by: Aditya Goel <[email protected]>
|
Thanks for the help 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the discussions in #163 and #164 and is a best effort solution to fill the type inferencing hole referenced.
I provided a short summary of the current state to make it easier to follow the current discussion.
Note: This is not a complete implementation as mentioned by the comment in #163.
Checklist
CHANGELOG.rstentry