Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI on pull requests #200

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Run CI on pull requests #200

merged 3 commits into from
Jan 3, 2025

Conversation

neNasko1
Copy link
Contributor

@neNasko1 neNasko1 commented Jan 3, 2025

Currently external PR-s, don't trigger the CI, which makes it harder to accept external fixes.
Example: #198

Checklist

  • Added a CHANGELOG.rst entry

@adityagoel4512
Copy link
Member

I think you can just imitate glum or metalearners: https://github.com/Quantco/metalearners/blob/main/.github/workflows/ci.yml#L2-L12

@neNasko1
Copy link
Contributor Author

neNasko1 commented Jan 3, 2025

I think you can just imitate glum or metalearners: https://github.com/Quantco/metalearners/blob/main/.github/workflows/ci.yml#L2-L12

Thank you for the suggestion 🚀

@adityagoel4512 adityagoel4512 merged commit d7c1792 into Quantco:main Jan 3, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants