Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of node.op in Split2QUnitaries (backport #13015) #13062

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 30, 2024

Summary

I believe this PR addresses the first point from #12970 but doesn't fully close the issue, there is still some digging to do in the pipeline.

Details and comments


This is an automatic backport of pull request #13015 done by [Mergify](https://mergify.com).

* Replace node.op with node.matrix

* Add docstring to test gate

* Fix black

(cherry picked from commit 623415c)
@mergify mergify bot requested a review from a team as a code owner August 30, 2024 19:57
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added this to the 1.2.1 milestone Aug 30, 2024
@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Aug 30, 2024
mtreinish
mtreinish previously approved these changes Aug 30, 2024
test/python/transpiler/test_split_2q_unitaries.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Aug 30, 2024

Pull Request Test Coverage Report for Build 10638667076

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.5%) to 89.002%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 5 91.98%
crates/qasm2/src/parse.rs 6 97.61%
Totals Coverage Status
Change from base Build 10636641589: -0.5%
Covered Lines: 33084
Relevant Lines: 37172

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Aug 30, 2024
Merged via the queue into stable/1.2 with commit 3e68b3e Aug 30, 2024
17 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.2/pr-13015 branch August 30, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants