Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all release notes from 1.2 into releasenotes/notes/1.2/ #13374

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

raynelfss
Copy link
Contributor

@raynelfss raynelfss commented Oct 28, 2024

Summary

The following commits move all of the release notes from 1.2 into the releasenotes/notes/1.2/ directory.

Details and comments

After the 1.2 release, the 1.2 release notes were not separated from all the newer releasenotes. These commits aim to fix that and add all of the missing release notes into a folder dedicated to it.

@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @mtreinish
  • @nkanazawa1989

@raynelfss raynelfss changed the title Move all release notes from 1.2 into releasenotes/notes/1.2/ Move all release notes from 1.2 into releasenotes/notes/1.2/ Oct 28, 2024
@raynelfss raynelfss added the documentation Something is not clear or an error documentation label Oct 28, 2024
@coveralls
Copy link

coveralls commented Oct 28, 2024

Pull Request Test Coverage Report for Build 11617477042

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1150 unchanged lines in 41 files lost coverage.
  • Overall coverage increased (+0.02%) to 88.707%

Files with Coverage Reduction New Missed Lines %
qiskit/circuit/library/boolean_logic/inner_product.py 1 96.0%
qiskit/transpiler/target.py 1 93.84%
qiskit/circuit/store.py 1 97.06%
qiskit/circuit/library/iqp.py 1 96.15%
qiskit/circuit/library/boolean_logic/quantum_or.py 1 98.08%
crates/accelerate/src/basis/basis_translator/basis_search.rs 1 99.31%
qiskit/circuit/library/boolean_logic/quantum_and.py 1 97.96%
qiskit/qasm2/export.py 1 98.48%
crates/accelerate/src/split_2q_unitaries.rs 2 96.43%
qiskit/transpiler/passes/optimization/echo_rzx_weyl_decomposition.py 2 97.01%
Totals Coverage Status
Change from base Build 11526575270: 0.02%
Covered Lines: 76360
Relevant Lines: 86081

💛 - Coveralls

@raynelfss raynelfss added the on hold Can not fix yet label Oct 28, 2024
@raynelfss
Copy link
Contributor Author

It seems there are more release notes that I didn't include. will continue adding more in follow-ups

@raynelfss raynelfss removed the on hold Can not fix yet label Oct 29, 2024
@raynelfss
Copy link
Contributor Author

I was able to add all of the missing release notes from 1.2, but for some reason reno would not recognize them when generating the release note pages. All of them still show up under "Unreleased Notes".

@raynelfss raynelfss requested a review from a team as a code owner October 31, 2024 18:10
@raynelfss raynelfss added this to the 1.3.0 milestone Nov 1, 2024
@raynelfss
Copy link
Contributor Author

raynelfss commented Nov 1, 2024

but for some reason reno would not recognize them when generating the release note pages. All of them still show up under "Unreleased Notes".

Apparently due to the nature of 1.2 we are not able to show it locally on the docs. This should be good to go now :)

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the effort of going through the renos.

@ElePT ElePT added this pull request to the merge queue Nov 1, 2024
Merged via the queue into Qiskit:main with commit 667ee8e Nov 1, 2024
17 checks passed
@raynelfss raynelfss added the Changelog: None Do not include in changelog label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants