Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump macos version in wheels gha workflow #12882

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

mtreinish
Copy link
Member

Summary

During the 1.2.0rc1 release process we had a failure to build the x86_64 macOS jobs. This was because the job was still trying to use the macos-11 runner which is no longer supported. [1] This commit fixes this by bumping the version in the wheel job to macos-12.

Details and comments

[1] https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/

During the 1.2.0rc1 release process we had a failure to build the x86_64
macOS jobs. This was because the job was still trying to use the
macos-11 runner which is no longer supported. [1] This commit fixes this
by bumping the version in the wheel job to macos-12.

[1] https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/
@mtreinish mtreinish added type: qa Issues and PRs that relate to testing and code quality stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Aug 1, 2024
@mtreinish mtreinish added this to the 1.2.0 milestone Aug 1, 2024
@mtreinish mtreinish requested a review from a team as a code owner August 1, 2024 20:15
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10205136733

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 89.772%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 92.73%
Totals Coverage Status
Change from base Build 10201486203: 0.02%
Covered Lines: 67362
Relevant Lines: 75037

💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Aug 2, 2024
Merged via the queue into Qiskit:main with commit 6663db1 Aug 2, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request Aug 2, 2024
During the 1.2.0rc1 release process we had a failure to build the x86_64
macOS jobs. This was because the job was still trying to use the
macos-11 runner which is no longer supported. [1] This commit fixes this
by bumping the version in the wheel job to macos-12.

[1] https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/

(cherry picked from commit 6663db1)
github-merge-queue bot pushed a commit that referenced this pull request Aug 2, 2024
During the 1.2.0rc1 release process we had a failure to build the x86_64
macOS jobs. This was because the job was still trying to use the
macos-11 runner which is no longer supported. [1] This commit fixes this
by bumping the version in the wheel job to macos-12.

[1] https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/

(cherry picked from commit 6663db1)

Co-authored-by: Matthew Treinish <[email protected]>
kevinhartman pushed a commit that referenced this pull request Aug 9, 2024
During the 1.2.0rc1 release process we had a failure to build the x86_64
macOS jobs. This was because the job was still trying to use the
macos-11 runner which is no longer supported. [1] This commit fixes this
by bumping the version in the wheel job to macos-12.

[1] https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/
@mtreinish mtreinish deleted the bump-macos-wheels branch August 9, 2024 16:06
eliarbel pushed a commit to eliarbel/qiskit that referenced this pull request Sep 24, 2024
During the 1.2.0rc1 release process we had a failure to build the x86_64
macOS jobs. This was because the job was still trying to use the
macos-11 runner which is no longer supported. [1] This commit fixes this
by bumping the version in the wheel job to macos-12.

[1] https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/

(cherry picked from commit 6663db1)
github-merge-queue bot pushed a commit that referenced this pull request Sep 25, 2024
During the 1.2.0rc1 release process we had a failure to build the x86_64
macOS jobs. This was because the job was still trying to use the
macos-11 runner which is no longer supported. [1] This commit fixes this
by bumping the version in the wheel job to macos-12.

[1] https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/

(cherry picked from commit 6663db1)

Co-authored-by: Matthew Treinish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants