Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump macos version in wheels gha workflow (backport #12882) #12888

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 2, 2024

Summary

During the 1.2.0rc1 release process we had a failure to build the x86_64 macOS jobs. This was because the job was still trying to use the macos-11 runner which is no longer supported. [1] This commit fixes this by bumping the version in the wheel job to macos-12.

Details and comments

[1] https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/


This is an automatic backport of pull request #12882 done by [Mergify](https://mergify.com).

During the 1.2.0rc1 release process we had a failure to build the x86_64
macOS jobs. This was because the job was still trying to use the
macos-11 runner which is no longer supported. [1] This commit fixes this
by bumping the version in the wheel job to macos-12.

[1] https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/

(cherry picked from commit 6663db1)
@mergify mergify bot requested a review from a team as a code owner August 2, 2024 09:12
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Aug 2, 2024
@github-actions github-actions bot added this to the 1.2.0 milestone Aug 2, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10213084176

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.007%) to 89.967%

Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 88.39%
crates/qasm2/src/lex.rs 3 92.48%
Totals Coverage Status
Change from base Build 10202481558: 0.007%
Covered Lines: 66748
Relevant Lines: 74192

💛 - Coveralls

@mtreinish mtreinish added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Aug 2, 2024
@jakelishman jakelishman added this pull request to the merge queue Aug 2, 2024
Merged via the queue into stable/1.2 with commit ded5957 Aug 2, 2024
18 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.2/pr-12882 branch August 2, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants