Fix type hint on find_basic_approximation in SolovayKitaevDecomposition #12627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return type hint of `find_basic_approximation` method changes from `Gate` to `GateSequence` in `SolovayKitaevDecomposition` class, as implied by `self.basic_approximations`. With no remaining mentions of `Gate`, its corresponding import statement is removed.
cstiago
requested review from
alexanderivrii,
ShellyGarion and
a team
as code owners
qiskit-bot
added
the
Community PR
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 9610004302Details
💛 - Coveralls |
ElePT
added
documentation
ElePT
approved these changes
Jun 21, 2024
ElePT
added
the
stable backport potential
|
https://github.com/Mergifyio backport stable/0.46 stable/1.1 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
The return type hint of `find_basic_approximation` method changes from `Gate` to `GateSequence` in `SolovayKitaevDecomposition` class, as implied by `self.basic_approximations`. With no remaining mentions of `Gate`, its corresponding import statement is removed. (cherry picked from commit 91f0c70)
mergify bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
The return type hint of `find_basic_approximation` method changes from `Gate` to `GateSequence` in `SolovayKitaevDecomposition` class, as implied by `self.basic_approximations`. With no remaining mentions of `Gate`, its corresponding import statement is removed. (cherry picked from commit 91f0c70)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
The return type hint of `find_basic_approximation` method changes from `Gate` to `GateSequence` in `SolovayKitaevDecomposition` class, as implied by `self.basic_approximations`. With no remaining mentions of `Gate`, its corresponding import statement is removed. (cherry picked from commit 91f0c70) Co-authored-by: Tiago R. Cunha <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
The return type hint of `find_basic_approximation` method changes from `Gate` to `GateSequence` in `SolovayKitaevDecomposition` class, as implied by `self.basic_approximations`. With no remaining mentions of `Gate`, its corresponding import statement is removed. (cherry picked from commit 91f0c70) Co-authored-by: Tiago R. Cunha <[email protected]>
cstiago
changed the title
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
The return type hint of `find_basic_approximation` method changes from `Gate` to `GateSequence` in `SolovayKitaevDecomposition` class, as implied by `self.basic_approximations`. With no remaining mentions of `Gate`, its corresponding import statement is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The return type hint of
find_basic_approximationmethod changes fromGatetoGateSequenceinSolovayKitaevDecompositionclass, as implied byself.basic_approximations.With no remaining mentions of
Gate, its corresponding import statement is removed.Details and comments
Fixes #12559.