Skip to content

Commit

Permalink
Fix type hint in SolovayKitaevDecomposition (Qiskit#12627)
Browse files Browse the repository at this point in the history
The return type hint of `find_basic_approximation` method changes from `Gate` to `GateSequence` in `SolovayKitaevDecomposition` class, as implied by `self.basic_approximations`.

With no remaining mentions of `Gate`, its corresponding import statement is removed.
  • Loading branch information
cstiago authored and Procatv committed Aug 1, 2024
1 parent fdbf962 commit 7456763
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions qiskit/synthesis/discrete_basis/solovay_kitaev.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@

import numpy as np

from qiskit.circuit.gate import Gate

from .gate_sequence import GateSequence
from .commutator_decompose import commutator_decompose
from .generate_basis_approximations import generate_basic_approximations, _1q_gates, _1q_inverses
Expand Down Expand Up @@ -157,14 +155,14 @@ def _recurse(self, sequence: GateSequence, n: int, check_input: bool = True) ->
w_n1 = self._recurse(w_n, n - 1, check_input=check_input)
return v_n1.dot(w_n1).dot(v_n1.adjoint()).dot(w_n1.adjoint()).dot(u_n1)

def find_basic_approximation(self, sequence: GateSequence) -> Gate:
"""Finds gate in ``self._basic_approximations`` that best represents ``sequence``.
def find_basic_approximation(self, sequence: GateSequence) -> GateSequence:
"""Find ``GateSequence`` in ``self._basic_approximations`` that approximates ``sequence``.
Args:
sequence: The gate to find the approximation to.
sequence: ``GateSequence`` to find the approximation to.
Returns:
Gate in basic approximations that is closest to ``sequence``.
``GateSequence`` in ``self._basic_approximations`` that approximates ``sequence``.
"""
# TODO explore using a k-d tree here

Expand Down

0 comments on commit 7456763

Please sign in to comment.