-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mw_ APIs for SOECPotential and SOECPComponent #4504
Conversation
src/QMCHamiltonians/SOECPotential.h
Outdated
///neighborlist of ions | ||
NeighborLists IonNeighborElecs; | ||
NeighborLists IonNeighborElecs_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put all the variable names in lower case. IonNeighborElecs_-> ion_neighbor_elecs_ to be compliant with up-to-date naming convention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Test this please |
Please review the developer documentation
on the wiki of this project that contains help and requirements.
Proposed changes
This PR add mw_ APIs for the SOECPotential and components, so now running in the batched code doesn't have to fall back to the single walker APIs. While designing the unit test, I also did a bit of refactoring in the potential and component classes. Also, a new standalone unit test was added similar to test_NonLocalECPotential.
part of #3712, finishes the last bullet point
What type(s) of changes does this code introduce?
Delete the items that do not apply
Does this introduce a breaking change?
What systems has this change been tested on?
my M1 mac
Checklist
Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.