Skip to content

Commit

Permalink
1.7.2 - Flutter upgrade to 3.3.7 (#141)
Browse files Browse the repository at this point in the history
* upgrading to flutter to version 3.3.7

* updating ios project to work with flutter 3.3.7
  • Loading branch information
mkieres authored Nov 12, 2022
1 parent 73a1ae5 commit 7d95802
Show file tree
Hide file tree
Showing 7 changed files with 28 additions and 34 deletions.
2 changes: 1 addition & 1 deletion board_games_companion/ios/Flutter/AppFrameworkInfo.plist
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
<key>CFBundleVersion</key>
<string>1.0</string>
<key>MinimumOSVersion</key>
<string>9.0</string>
<string>11.0</string>
</dict>
</plist>
2 changes: 1 addition & 1 deletion board_games_companion/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ SPEC CHECKSUMS:
FirebaseCoreInternal: 635d1c9a612a6502b6377a0c92af83758076ffff
FirebaseCrashlytics: 9fff819edb2bfc9d3eff612225b207d41945a935
FirebaseInstallations: 54b40022cb06e462740c9f2b9fbe38b5e78a825a
Flutter: 50d75fe2f02b26cc09d224853bb45737f8b3214a
Flutter: f04841e97a9d0b0a8025694d0796dd46242b2854
FMDB: 2ce00b547f966261cd18927a3ddb07cb6f3db82a
GoogleAppMeasurement: 7a33224321f975d58c166657260526775d9c6b1a
GoogleDataTransport: 5fffe35792f8b96ec8d6775f5eccd83c998d5a3b
Expand Down
12 changes: 6 additions & 6 deletions board_games_companion/ios/Runner.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
MTL_ENABLE_DEBUG_INFO = NO;
SDKROOT = iphoneos;
SUPPORTED_PLATFORMS = iphoneos;
Expand All @@ -444,7 +444,7 @@
"$(PROJECT_DIR)/Flutter",
);
INFOPLIST_FILE = Runner/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand Down Expand Up @@ -509,7 +509,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
MTL_ENABLE_DEBUG_INFO = YES;
ONLY_ACTIVE_ARCH = YES;
SDKROOT = iphoneos;
Expand Down Expand Up @@ -558,7 +558,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
MTL_ENABLE_DEBUG_INFO = NO;
SDKROOT = iphoneos;
SUPPORTED_PLATFORMS = iphoneos;
Expand Down Expand Up @@ -586,7 +586,7 @@
"$(PROJECT_DIR)/Flutter",
);
INFOPLIST_FILE = Runner/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand Down Expand Up @@ -622,7 +622,7 @@
"$(PROJECT_DIR)/Flutter",
);
INFOPLIST_FILE = Runner/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand Down
2 changes: 1 addition & 1 deletion board_games_companion/lib/common/app_theme.dart
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ class AppTheme {
),
textButtonTheme: TextButtonThemeData(
style: TextButton.styleFrom(
primary: AppColors.accentColor,
foregroundColor: AppColors.accentColor,
),
),
textTheme: originalTextTheme.copyWith(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import 'dart:math';
import 'package:basics/basics.dart';
import 'package:board_games_companion/common/enums/order_by.dart';
import 'package:board_games_companion/common/enums/sort_by_option.dart';
import 'package:board_games_companion/extensions/string_extensions.dart';
import 'package:board_games_companion/models/sort_by.dart';
import 'package:board_games_companion/stores/board_games_filters_store.dart';
import 'package:board_games_companion/stores/user_store.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,14 @@ class PlaythroughsPageState extends BasePageState<PlaythroughsPage>
onPressed: () async => _openGamesMusicPlaylist(context),
),
Observer(
builder: (_) {
builder: (BuildContext context) {
if (!widget.viewModel.hasUser) {
return const SizedBox.shrink();
}

return IconButton(
icon: const Icon(Icons.download, color: AppColors.accentColor),
onPressed: () => _importBggPlays(),
onPressed: () => _importBggPlays(context),
);
},
),
Expand Down Expand Up @@ -168,7 +168,7 @@ class PlaythroughsPageState extends BasePageState<PlaythroughsPage>
);
}

Future<void> _importBggPlays() async {
Future<void> _importBggPlays(BuildContext context) async {
try {
setState(() {
_showImportGamesLoadingIndicator = true;
Expand All @@ -186,7 +186,9 @@ class PlaythroughsPageState extends BasePageState<PlaythroughsPage>
widget.viewModel.bggPlaysImportRaport!,
);
} else {
_showNoPlaysToImportDialog();
if (mounted) {
_showNoPlaysToImportDialog(context);
}
}
} catch (e, stack) {
FirebaseCrashlytics.instance.recordError(e, stack);
Expand All @@ -197,7 +199,7 @@ class PlaythroughsPageState extends BasePageState<PlaythroughsPage>
}
}

void _showNoPlaysToImportDialog() {
void _showNoPlaysToImportDialog(BuildContext context) {
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
behavior: SnackBarBehavior.floating,
Expand Down
31 changes: 12 additions & 19 deletions board_games_companion/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ packages:
name: async
url: "https://pub.dartlang.org"
source: hosted
version: "2.8.2"
version: "2.9.0"
basics:
dependency: "direct main"
description:
Expand Down Expand Up @@ -140,14 +140,7 @@ packages:
name: characters
url: "https://pub.dartlang.org"
source: hosted
version: "1.2.0"
charcode:
dependency: transitive
description:
name: charcode
url: "https://pub.dartlang.org"
source: hosted
version: "1.3.1"
version: "1.2.1"
checked_yaml:
dependency: transitive
description:
Expand All @@ -161,7 +154,7 @@ packages:
name: clock
url: "https://pub.dartlang.org"
source: hosted
version: "1.1.0"
version: "1.1.1"
code_builder:
dependency: transitive
description:
Expand Down Expand Up @@ -259,7 +252,7 @@ packages:
name: fake_async
url: "https://pub.dartlang.org"
source: hosted
version: "1.3.0"
version: "1.3.1"
ffi:
dependency: transitive
description:
Expand Down Expand Up @@ -694,21 +687,21 @@ packages:
name: matcher
url: "https://pub.dartlang.org"
source: hosted
version: "0.12.11"
version: "0.12.12"
material_color_utilities:
dependency: transitive
description:
name: material_color_utilities
url: "https://pub.dartlang.org"
source: hosted
version: "0.1.4"
version: "0.1.5"
meta:
dependency: transitive
description:
name: meta
url: "https://pub.dartlang.org"
source: hosted
version: "1.7.0"
version: "1.8.0"
mime:
dependency: transitive
description:
Expand Down Expand Up @@ -771,7 +764,7 @@ packages:
name: path
url: "https://pub.dartlang.org"
source: hosted
version: "1.8.1"
version: "1.8.2"
path_drawing:
dependency: transitive
description:
Expand Down Expand Up @@ -1000,7 +993,7 @@ packages:
name: source_span
url: "https://pub.dartlang.org"
source: hosted
version: "1.8.2"
version: "1.9.0"
sprintf:
dependency: "direct main"
description:
Expand Down Expand Up @@ -1049,7 +1042,7 @@ packages:
name: string_scanner
url: "https://pub.dartlang.org"
source: hosted
version: "1.1.0"
version: "1.1.1"
synchronized:
dependency: transitive
description:
Expand All @@ -1063,14 +1056,14 @@ packages:
name: term_glyph
url: "https://pub.dartlang.org"
source: hosted
version: "1.2.0"
version: "1.2.1"
test_api:
dependency: transitive
description:
name: test_api
url: "https://pub.dartlang.org"
source: hosted
version: "0.4.9"
version: "0.4.12"
timing:
dependency: transitive
description:
Expand Down

0 comments on commit 7d95802

Please sign in to comment.