Make rating mandatory

[leemyongpakvn]

Questions	Answers
Description?	Make rating mandatory. Please check detail in related issue.
Type?	improvement
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#26001
How to test?	Apply PR changes then check to make sure that Review with Empty Title, Name, Content or not chosen Rating won't be accepted. (Don't forget to use a clean dev branch, FO - clear Browser cache, BO - clear PS cache before testing ;)

[matthieu-rolland]

thank you for taking care of this 👍

there is no backend validation for this rating mechanism ?

[leemyongpakvn]

@matthieu-rolland No, this PR just add rating not Chosen check like Review's title, author and content Empty check in the same front-end validation function validateFormData. Furthermore, ratingChosen variable is set programmatically (not by a user input) and won't be saved to DB, so there is no need for back-end validation.

[florine2623]

Hello @leemyongpakvn ,

On classic theme it works like expected.

Although, I think the color should be the same red as the red in the message alert :

Also, it should the vertically alight to the right.

But on hummingbird, it doesn't work.

Could you make it compatible for both themes ?

Screen.Recording.2024-01-23.at.14.30.55.mov

Could you check ? :)
Thanks!

[leemyongpakvn]

@florine2623 ratingNotChosen message's Color and Alignment are changed following your suggestion. An implementation of this PR for hummingbird theme is also added PrestaShop/hummingbird#577.

[paulnoelcholot]

Hello @leemyongpakvn,

I tested your PR on classic theme and hummingbird and I got this :

Can you check it please?

Thanks!

[leemyongpakvn]

@paulnoelcholot Did you remember to apply FO - clear Browser cache, BO - clear PS cache before testing ?

[AureRita]

Hi @leemyongpakvn

Thank you for your PR, I tested it and it seems to works as you can see :

recording.79.webm

Unfortunately, you can also see that if you clic again on "Write your review" after put none rate on the product, you still have "* Please choose a rating for your review."

Can you check it ?

Thank you

[leemyongpakvn]

@AureRita I saw and fixed it with my 5th commit. Please check again.

[AureRita]

Thank you for your changes, now the problem is on the other way, when you put a rate, press send (to have the message that is hidden) close the modal and want to write a new review without rate, you didn't have the error message, as you can see :

recording.81.webm

Waiting for your next changes 🚀

Thank you

[leemyongpakvn]

@AureRita In the scenario: when you put a rate, press send OR just close the modal without send, then try to make a new review without rate it means you are already aware of the need to put a rate. So it can be a nuisance when keeping the warning message there :) Wdyt @MatShir ?

[matks]

Code is good for me 👍

[leemyongpakvn]

@AureRita As discussed in Slack, Krystian agreed with you, so I have changed the code following your opinion. Please check again.

[MatShir]

@leemyongpakvn thanks for making the effort 🤗
Late answer (sorry), Consistent error message for a better UX is always appreciated

[AureRita]

Hi @leemyongpakvn

Thank you for your PR, I tested it and it seems to works as you can see :

recording.91.webm

Because the PR seems to works as expected on develop and 8.1.x, It's QA ✔️

Thank you for all your best efforts ! 🚀

[leemyongpakvn]

Thanks to all ;)