Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

productcomments - Make rating mandatory #577

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

leemyongpakvn
Copy link
Contributor

Questions Answers
Description? Implementation of productcomments' MakeReviewMadatory for hummingbird
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #PrestaShop/PrestaShop/issues/26001
Sponsor company Your company or customer's name goes here (if applicable).
How to test? Apply PR change then check to make sure Review with Empty title, author, description or NotChosen rating won't be accepted.
(Don't forget to clone a clean develop branch of hummingbird, as well as clear browser cache, PS cache before testing ;)

paulnoelcholot
paulnoelcholot approved these changes Jan 25, 2024
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking not to merge before productcomments PR.

@leemyongpakvn
Copy link
Contributor Author

@paulnoelcholot Please recheck PrestaShop/productcomments#197

@AureRita
Copy link

AureRita commented Feb 6, 2024

Hi @kpodemski,

The PR is now merged,

@leemyongpakvn can you apply your last changes on this PR ?

Thank you

@leemyongpakva
Copy link
Contributor

@AureRita The last commit in PrestaShop/productcomments#197 stays in module's JS. There is no change needed for theme.

@leemyongpakva
Copy link
Contributor

@kpodemski The productcomments PR is now merged.

@leemyongpakva
Copy link
Contributor

@AureRita We are in need or re-QA

@AureRita AureRita self-assigned this Mar 15, 2024
@AureRita
Copy link

Hi @leemyongpakva

Thank you for your PR, I tested it and it seems to works as you can see :

recording.141.webm

Tested on develop and 8.1.x

Because the PR seems to works as expected, It's QA ✔️

Thank you

@nicosomb nicosomb added this to the Beta milestone Mar 18, 2024
@nicosomb nicosomb merged commit 0d083dc into PrestaShop:develop Mar 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

10 participants