Bump actions ubuntu 24.04

[figueroa1395]

Partially solves #773. Only upgrading the clang-tidy workflow to ubuntu-24.04 and clang-tidy itself to version 18.1.3 are left; however, discussion on how to resolve each resulting issue of this upgrade is out of scope of this PR.

---

This in an experiment PR to try to bump to Ubuntu 24.04 in github actions.

In actions/runner-images#10636, it is stated that ubuntu-latest won't fully migrate to 24.04 until October 30th, hence the explicit versioning in 6032f72.

Relevant tools, packages, etc. are updated to the latest supported by this Ubuntu image as stated in https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md

[figueroa1395]

Just to keep track of the experiment, after a full migration attempt (Ubuntu 24.04 with clang 18, python 3.12, etc.), there seem to be three major places that would need work:

• Code quality check: Formatting of several files (mainly header files).
• Clang tidy: About 60 errors (from warnings) from all over the core.
• Validate citations: Citations are broken.

In addition, I would expect the nighly build to uncover even more errors from clang-tidy.

[TonyXiang8787]

We need to discuss case-by-case about the clang-tidy stuff.

[figueroa1395]

We need to discuss case-by-case about the clang-tidy stuff.

We can add it to the knowledge sharing session this Thursday (if time allows), so we can all take a look. Should I tell Peter about it?

Side note: Force pushed some commits because I forgot to sign off the ones reverting some changes. Moreover, all changes were reverted (except for only bumping Ubuntu to 24.04), to see what would be the effect of this isolated change in our CI.

[figueroa1395]

It seems like the "isolated" experiment of only bumping to Ubuntu 24.04 arguably breaks things even more.

[mgovers]

Yeah we definitely need to talk about it then. This will become a blocker on oct 30th Op 8 okt 2024 17:18 schreef Santiago Figueroa Manrique ***@***.***>: It seems like the "isolated" experiment of only bumping to Ubuntu 24.04 arguably breaks things even more. — Reply to this email directly, view it on GitHub<#770 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADUHKF2UCKBWN744QM7GNDDZ2PZUXAVCNFSM6AAAAABPSIKKFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBQGE2DINZRGU>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[TonyXiang8787]

It seems like the "isolated" experiment of only bumping to Ubuntu 24.04 arguably breaks things even more.

If you only bump Ubuntu 24.04, it still uses clang-15 compiler but with gcc-14 C++ std library. This causes the issue with many errors. The error should be less if you bump the clang version to clang-18.

[figueroa1395]

If you only bump Ubuntu 24.04, it still uses clang-15 compiler but with gcc-14 C++ std library. This causes the issue with many errors. The error should be less if you bump the clang version to clang-18.

I'll try this and fix the ReadTheDocs version as well. Additionally I may try a fix for the validate-citations action.

[mgovers]

It seems like the "isolated" experiment of only bumping to Ubuntu 24.04 arguably breaks things even more.

If you only bump Ubuntu 24.04, it still uses clang-15 compiler but with gcc-14 C++ std library. This causes the issue with many errors. The error should be less if you bump the clang version to clang-18.

see the first experiment: bumping to clang-18 works but clang-tidy-18 complains. we need to decide on the path going forward and refine - most likely in the afternoon.

We don't need to do that. Just use ubuntu-latest. It is already default 24.04.

it is released but not yet the default - migration from 22.04 to 24.04 is going gradually, with the migration expected to be finished on 2024 October 30. This experiment mainly checks whether it will work in the first place. Turns out it did for the check-code-quality.yml (so we can keep that action at ubuntu-latest) but not for the main.yml action (so we need to pin and migrate manually)

[TonyXiang8787]

It seems like the "isolated" experiment of only bumping to Ubuntu 24.04 arguably breaks things even more.

If you only bump Ubuntu 24.04, it still uses clang-15 compiler but with gcc-14 C++ std library. This causes the issue with many errors. The error should be less if you bump the clang version to clang-18.

see the first experiment: bumping to clang-18 works but clang-tidy-18 complains. we need to decide on the path going forward and refine - most likely in the afternoon.

We don't need to do that. Just use ubuntu-latest. It is already default 24.04.

it is released but not yet the default - migration from 22.04 to 24.04 is going gradually, with the migration expected to be finished on 2024 October 30. This experiment mainly checks whether it will work in the first place. Turns out it did for the check-code-quality.yml (so we can keep that action at ubuntu-latest) but not for the main.yml action (so we need to pin and migrate manually)

If we bump to clang-18, most of the errors in other workflow should be gone, if not all of them. And yes, we still need to fix clang-tidy. To decide per category to either ignore the warning (like large enum type), or fix the issue.

[figueroa1395]

To keep track of the experiment:

• Not upgrading clang-format behaves as expected: The code quality check passes.
• Upgrading only clang to version 18.1.3. (but not clang-tidy) still breaks the clang-tidy action. However, sonar-cloud doesn't complain anymore.

Following I will upgrade clang-tidy (but not clang-format) and attempt to fix the failed validate-citations action.

[figueroa1395]

Conclusions at this point:

• 7f8ee76 fixed the validate-citations action.
• When upgrading clang-tidy and clang to version 18.1.3, the clang-tidy action breaks, and we need to address it case by case.

Furthermore, an issue was created as a result of this experiment.

[TonyXiang8787]

@figueroa1395 please do a down merge before you run the clang-format

[figueroa1395]

The manual nightly build failed for reasons out of scope of this PR. This nightly build fail issue is to be tackled in a different PR. Merging now.

[sonarcloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud