You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On October 30th, 2024, ubuntu-release will be fully migrated to ubuntu-24.04 for github actions. This feature request is about upgrading along to ubuntu-24.04. For reference here are the list packages, tools, etc. that come with this image and here is the announcement of this image and its implications.
Steps
This is the list of things that need to be done to do the full migration:
Upgrade to ubuntu-24.04 (or ubuntu-release after October 30th) for github actions.
Upgrade clang and clang-format to version 18.1.3. This involves also updating llvm to version 18.
Upgrade gcc and g++ to version 13 (14 is experimental in ubuntu-24-04).
Upgrade python to 3.12 in the github actions.
Update pre-commit accordingly.
Update build-guide (improving it is out of scope).
Upgrade clang-tidy to version 18.1.3 and resolve all the resulting conflicts.
Experiment
An experiment was run on #770 to see what would the impact be to do the migration, and the main conclussions are:
If clang-format is upgraded, the check-code-quality action breaks and many files need to be re-formatted again (also pre-commit needs to align with the versions here)
If clang (but not clang-tidy) is upgraded, the clang-tidy action breaks horribly. If both clang and clang-tidy are upgraded, many fixes need to happen accross the core, as the clang-tidy action breaks. These probably need to be evaluated in a per-case scenario.
The above seem to be the only problems with the migration (without considering the cmakeupgrade which may be a follow up).
Takeout
The hard deadline to take action is October 30th, 2024, so we probably need to either address the above issues or pin github actions to ubuntu-22.04.
The text was updated successfully, but these errors were encountered:
Partially solved in #770. Only remaining task is to upgrade clang-tidy to 18.1.3. and to resolve all the resulting problems. This is to be done after taking action on a per-issue basis with the team.
Describe the feature request
On October 30th, 2024,
ubuntu-release
will be fully migrated toubuntu-24.04
for github actions. This feature request is about upgrading along toubuntu-24.04
. For reference here are the list packages, tools, etc. that come with this image and here is the announcement of this image and its implications.Steps
This is the list of things that need to be done to do the full migration:
ubuntu-24.04
(orubuntu-release
after October 30th) for github actions.clang
andclang-format
to version 18.1.3. This involves also updatingllvm
to version 18.gcc
andg++
to version 13 (14 is experimental inubuntu-24-04
).python
to 3.12 in the github actions.pre-commit
accordingly.clang-tidy
to version 18.1.3 and resolve all the resulting conflicts.Experiment
An experiment was run on #770 to see what would the impact be to do the migration, and the main conclussions are:
clang-format
is upgraded, the check-code-quality action breaks and many files need to be re-formatted again (also pre-commit needs to align with the versions here)clang
(but notclang-tidy
) is upgraded, the clang-tidy action breaks horribly. If bothclang
andclang-tidy
are upgraded, many fixes need to happen accross the core, as the clang-tidy action breaks. These probably need to be evaluated in a per-case scenario.The above seem to be the only problems with the migration (without considering the
cmake
upgrade which may be a follow up).Takeout
The hard deadline to take action is October 30th, 2024, so we probably need to either address the above issues or pin github actions to
ubuntu-22.04
.The text was updated successfully, but these errors were encountered: