fix(all): improve a11y of our site per a user request #26992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
adamleithp
approved these changes
Dec 17, 2024
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We got this ticket (it was in the feature flags queue, which is why i saw it) that explained how our site isn't particularly accessible, but that there was an easy fix for it! I tried out the fix and it seemed to work, so figured I'd make a PR and then discuss if this seems feasible.
Gonna tag the design system heads (@Twixes and @daibhin and also ask the new devex team).
Changes
New behavior: https://www.loom.com/share/c88df307a1744666b9e919f12a65b3d8