-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed search bar layout and ux: can now click to preview search results #27015
Conversation
…sktop, new layout results in less janky keyboard navigation
👏 Yesssss. Only feedback: What if we moved the keyboard shortcut inside the button so we don't duplicate the text? Like:
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvements, just finding the focus-visible styling odd, and +1 to Cory's point
22e00c8
to
f6d2a1e
Compare
I generally like it! Wdyt? (I think we can tweak later but imo 🚀?) |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice
Loom: https://www.loom.com/share/e709b159112b42cb991d3a302424b825?sid=d4dde375-3c7d-49df-a805-39635f4f279a
Problem
I found the UX of the search bar hard to understand:
Search input now hasfocus-visible
outline styles.I found the layout of the search bar:
Changes
focus-visible
outline styles.Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Opened on major browsers (both keyboard functionality and clicking), tested mobile