Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(experiments): Use absolute_exposure not relative exposure #26872

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix(experiments): Use absolute_exposure not relative exposure #26872

merged 1 commit into from
Dec 13, 2024

Conversation

danielbachhuber
Copy link
Contributor

See #26713

Changes

Use absolute_exposure, not relative exposure, in calculate_probabilities_v2.

How did you test this code?

Tests should pass.

@danielbachhuber danielbachhuber requested a review from a team December 12, 2024 13:21
jurajmajerik
jurajmajerik approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@jurajmajerik jurajmajerik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch 👍

@danielbachhuber danielbachhuber merged commit cf7b3e7 into master Dec 13, 2024
90 checks passed
@danielbachhuber danielbachhuber deleted the experiments/fix-trends-probabilities branch December 13, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurajmajerik jurajmajerik jurajmajerik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielbachhuber @jurajmajerik