Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experiments): Hide internal and test user filter for DW #26818

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

danielbachhuber
Copy link
Contributor

See #26332 (comment)
See https://posthog.slack.com/archives/C07PXH2GTGV/p1733847219869179

Changes

Hides the "Filter out internal and test users" toggle for data warehouse goals. If the data warehouse is picked as a goal, then filterTestAccounts is also set to false.

CleanShot 2024-12-10 at 15 21 14

How did you test this code?

Manual testing

@danielbachhuber danielbachhuber requested a review from a team December 10, 2024 23:25
Copy link
Contributor

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@danielbachhuber danielbachhuber merged commit ec60065 into master Dec 12, 2024
97 checks passed
@danielbachhuber danielbachhuber deleted the experiments/hide-test-account-filter-switch branch December 12, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants