Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experiments): Prevent Goal component from crashing #26896

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

danielbachhuber
Copy link
Contributor

@danielbachhuber danielbachhuber commented Dec 13, 2024

Introduced in #26818

Addresses https://posthog.sentry.io/issues/6138030309/ and https://posthog.sentry.io/issues/6138027513/

Changes

Fixes the goal component for Funnels.

How did you test this code?

I opened both trends and funnel experiments to verify neither crashed.

@danielbachhuber danielbachhuber requested a review from a team December 13, 2024 12:59
@danielbachhuber danielbachhuber enabled auto-merge (squash) December 13, 2024 13:02
Copy link
Contributor

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@danielbachhuber danielbachhuber merged commit 646de76 into master Dec 13, 2024
99 checks passed
@danielbachhuber danielbachhuber deleted the experiments/fix-goal branch December 13, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants