Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass through billing query params #26714

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Conversation

zlwaterfield
Copy link
Contributor

@zlwaterfield zlwaterfield commented Dec 6, 2024

Changes

We support include_forecasting in billing now so we should add pass through support.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

It doesn't have an impact.

How did you test this code?

Added a test

@zlwaterfield zlwaterfield changed the title add billing query params pass through feat: pass through billing query params Dec 6, 2024
@zlwaterfield zlwaterfield self-assigned this Dec 6, 2024
@zlwaterfield zlwaterfield marked this pull request as ready for review December 6, 2024 11:08
@patricio-posthog patricio-posthog merged commit 368a40c into master Dec 6, 2024
89 checks passed
@patricio-posthog patricio-posthog deleted the zach/billing-params branch December 6, 2024 15:18
Copy link

sentry-io bot commented Dec 6, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Exception: ('Billing service returned bad status code: 504', 'body:', '\r\n<title>504 Gateway Ti... /api/billing/ View Issue
  • ‼️ Organization.DoesNotExist: Organization matching query does not exist. /api/billing/ View Issue
  • ‼️ ConnectionError: HTTPSConnectionPool(host='billing.posthog.com', port=443): Max retries exceeded with url: /api/bi... /api/billing/ View Issue
  • ‼️ OperationalError: consuming input failed: server closed the connection unexpectedly /api/billing/ View Issue
  • ‼️ Exception: ('Billing service returned bad status code: 500', 'body:', {'type': 'server_error', 'code': 'erro... /api/billing/ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants